Fix --fail-graph when there is indirect cycles #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indirect cycles Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com>
JeanChristopheMorinPerso
changed the title
JeanChristopheMorinPerso
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Thanks you so much @Pantsworth and thank you for taking the time to add a test!
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
merged commit 4209c8b
into
AcademySoftwareFoundation:main
54 of 55 checks passed
Pixel-Minions
pushed a commit
to Pixel-Minions/rez
that referenced
this pull request
Feb 14, 2024
…tion#1620) Fix --fail-graph when there is indirect cycles (AcademySoftwareFoundation#1620) Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Signed-off-by: Jose Enriquez <jose.enriquez@barnstormvfx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568
Bugfix to support graphing resolves if they have cycles from using "!" requirements.