-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package orderers documentation #1737
Add package orderers documentation #1737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start. I made small comments that shouldn't be too difficult to address.
We should also be careful to not drop or have duplicated information with https://rez--1737.org.readthedocs.build/en/1737/configuring_rez.html#package_orderers.
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Bryce Gattis <36783788+BryceGattis@users.noreply.github.com>
102cfc8
to
d051ebb
Compare
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 59.30% 59.30%
=======================================
Files 126 126
Lines 17210 17210
Branches 3015 3015
=======================================
Hits 10206 10206
Misses 6319 6319
Partials 685 685 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@BryceGattis I pushed some changes. When you have a minute, could you take a look and tell me if what I wrote is clear please? |
@JeanChristopheMorinPerso The changes you made were great thank you. The one lingering question I have is that I'm still not fully understanding the purpose of the |
@JeanChristopheMorinPerso What do you think about having a glossary for rez? I was just thinking that a clickable link for |
Thanks @BryceGattis for taking some time to look at my changes! I agree that we need a glossary, but I think this can be done in a separate PR. |
7b6e4fa
into
AcademySoftwareFoundation:main
Looking for some feedback on what exactly this page should look like. Some examples of the configuration are on the configuring rez page, but I'm not sure if we want the same kind of info here or not.