Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when subclassing rez.command.Command caused by accessing a non-existent config entry #1788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

predat
Copy link
Contributor

@predat predat commented Jul 4, 2024

extension have been replace by command

extension have been replace by command
@predat predat requested a review from a team as a code owner July 4, 2024 15:02
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.39%. Comparing base (e215a77) to head (7b945c8).
Report is 3 commits behind head on main.

Files Patch % Lines
src/rez/command.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1788   +/-   ##
=======================================
  Coverage   58.39%   58.39%           
=======================================
  Files         126      126           
  Lines       17205    17205           
  Branches     3519     3519           
=======================================
  Hits        10047    10047           
  Misses       6491     6491           
  Partials      667      667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso
Copy link
Member

Thanks @predat! Would you be willing to add a test? It should be relatively straight forward.

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Fix command.py Fix error when subclassing rez.command.Command caused by accessing a non-existent config entry Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants