Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test commands defined as list that result in an empty command #1850

Conversation

JeanChristopheMorinPerso
Copy link
Member

Fixes #1525

Fix test commands defined as list that result in an empty command when verbosity is enabled.

…n verbosity is enabled

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner October 14, 2024 17:02
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.58%. Comparing base (102c8e7) to head (484d625).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/package_test.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1850   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files         126      126           
  Lines       17207    17207           
  Branches     3014     3015    +1     
=======================================
  Hits        10080    10080           
  Misses       6474     6474           
  Partials      653      653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 84c827d into AcademySoftwareFoundation:main Oct 14, 2024
46 of 47 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the fix_test_commands_as_list branch October 14, 2024 17:07
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test command doesn't run when defined as list
1 participant