New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Popen with check_output to catch errors in installation #778

Merged

nerdvegas merged 1 commit into AcademySoftwareFoundation:master from instinct-vfx:bug/issue_777

Nov 6, 2019

Contributor

instinct-vfx commented Oct 28, 2019

Fixes #777 by replacing Popen with check_output. This raises an exception automatically and causes the rest of install.py to fail.


          Replace Popen with check_output to catch errors in installation

ad7a6a9

JeanChristopheMorinPerso approved these changes

View reviewed changes

Member

JeanChristopheMorinPerso left a comment

Looks good to me. Thanks for the fix :)

nerdvegas merged commit ad7a6a9 into AcademySoftwareFoundation:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet