-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rez.pip: Support python 2 executable on Windows (796) #798
rez.pip: Support python 2 executable on Windows (796) #798
Conversation
Another way to deal with it is https://www.python.org/dev/peps/pep-0397/
Not sure if it is guaranteed to be installed but once it is there is solves a bunch of issues. |
@bfloch thanks for pointing this out. I just don't know if it's available in all Python versions. I think we can go with the current solution as it's quite simple and won't bring us much support I think. |
I think python launcher was added with 3.3 but i am not sure. 2.7 does not ship with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the easiest way to fix the issue.
On windows both Python 2.7 and 3.x will be plain My thought was that a more reliable detection would be on windows to try If it is not available just roll as is - since in this case it is likely you only have python 2.x installed anyway. I just can't see how |
ef38bb2
to
152b341
Compare
Happy to go with this until proven otherwise that we need something more complex. This and some other recent PR merges coming soon. Cheers all |
Fair. I have not yet studied |
Fixes #796.
On Windows, versions of Python less than 2 doesn't have versioned executable... So I'm basically just adding a check for windows and only append the version when not under windows.