Issue 800 windows ci use checkout #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 12, 2019 15:32
bfloch
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Tested on my fork. Works and fixes PRs. Wonderful!
I guess we could rebase to get rid of those CI triggers if you care for a cleaner history.
On that note, just posted to Slack: I discovered that when you push and it fails the Windows workflow while building the image - you can go into the failed workflow after the image is pushed and Re-check Suite to trigger it. It will run correctly as it is tagged with the same commit. Not perfect but requires no additional commits/pushes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #800