Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add 'prefix' argument to rez-pip #802

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Feature/add 'prefix' argument to rez-pip #802

merged 3 commits into from
Nov 26, 2019

Conversation

predat
Copy link
Contributor

@predat predat commented Nov 12, 2019

This PR offers the option to customize the installation location of a pip package using rez-pip.

instinct-vfx
instinct-vfx reviewed Nov 12, 2019
View reviewed changes
src/rez/cli/pip.py Outdated Show resolved Hide resolved
@predat predat changed the title Feature/add install_path argument to rez-pip Feature/add 'prefix' argument to rez-pip Nov 12, 2019
instinct-vfx
instinct-vfx approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@instinct-vfx instinct-vfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@JeanChristopheMorinPerso
Copy link
Member

@predat, I'm curious to know your use case here. Do you have any example of when this would be useful?

@predat
Copy link
Contributor Author

predat commented Nov 13, 2019

@JeanChristopheMorinPerso, here are the use cases I think about:

  • in my studio, we have a very deep packages structure and the REZ_RELEASE_PACKAGES_PATH variable is not always adequate
  • to do some tests
  • in case the packages path is dynamic
  • in case the packages path is contextual
  • because the rez-build command already has this argument
  • and I'm probably forgetting some...

@nerdvegas nerdvegas merged commit 262fe07 into AcademySoftwareFoundation:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instinct-vfx instinct-vfx instinct-vfx approved these changes

@nerdvegas nerdvegas Awaiting requested review from nerdvegas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@predat @JeanChristopheMorinPerso @instinct-vfx @nerdvegas