Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed odd case of _Bound instantiation with Version #815

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

nerdvegas
Copy link
Contributor

Also added some minor optimisations - the results of version range parse can be ifelse'd rather than if'd, since the regex can only match one of the OR'd statements in the regex at any one time.

#
version_group = r"([0-9a-zA-Z_]+(?:[.-][0-9a-zA-Z_]+)*)"

version_range_regex = (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: formatting change only, no change to regex here

@nerdvegas nerdvegas merged commit 8369577 into master Dec 12, 2019
@bpabel bpabel deleted the issue_814-odd-version-bug branch January 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant