Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor module-accounts #588

Merged
merged 5 commits into from
Dec 2, 2020
Merged

refactor module-accounts #588

merged 5 commits into from
Dec 2, 2020

Conversation

wangjj9219
Copy link
Member

@wangjj9219 wangjj9219 commented Nov 29, 2020 •
edited
Loading

Partially completed #566

  1. Remove open account deposit & related code of module_accounts
  2. Config System instead of Accounts as the AccountStore for pallet_balances
  3. rename module_accounts to module_transaction_payment
  4. redefine some hooks of module_evm_accounts and module_evm

@wangjj9219 wangjj9219 marked this pull request as draft November 29, 2020 07:29
xlc
xlc reviewed Nov 29, 2020
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use a non-zero existential deposit for tests

modules/accounts/src/lib.rs Outdated Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
@wangjj9219 wangjj9219 marked this pull request as ready for review November 30, 2020 11:04
@xlc xlc requested a review from zjb0807 November 30, 2020 21:51
@wangjj9219 wangjj9219 merged commit d125a75 into master Dec 2, 2020
@wangjj9219 wangjj9219 deleted the update-account-existence branch December 2, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@zjb0807 zjb0807 Awaiting requested review from zjb0807

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangjj9219 @xlc