Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-open do not need "true" as value #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

data-open do not need "true" as value #13

wants to merge 1 commit into from

Conversation

ryuran
Copy link

@ryuran ryuran commented Jun 17, 2020

Consider data-open without value as true.
Only consider data-open="false" as false.

@enwin enwin self-requested a review June 18, 2020 07:58
@enwin enwin self-assigned this Jun 18, 2020
@enwin enwin requested a review from dpetton June 18, 2020 08:03
@enwin enwin requested a review from sdussaut June 18, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdussaut sdussaut sdussaut approved these changes

@enwin enwin enwin approved these changes

@dpetton dpetton Awaiting requested review from dpetton

Assignees

@enwin enwin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryuran @sdussaut @enwin