Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _tasks.md #145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update _tasks.md #145

wants to merge 2 commits into from

Conversation

nick-clark84
Copy link
Collaborator

Added | date_started | to line 565
added | started | to line 256

As per instruction in https://affinitylive.jira.com/browse/AFFINITY-35257

Added | date_started | to line 565
added | started | to line 256

As per instruction in https://affinitylive.jira.com/browse/AFFINITY-35257
Copy link
Member

@Timothy-Edwards Timothy-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things from me, let me know if you need a hand with anything

@@ -223,7 +223,7 @@ This request supports the [pagination](#configuring-the-response-pagination) par
##### Additional Fields and Linked Objects
This request supports requesting additional fields and linked objects from the [task object](#the-task-object) using the [`_fields`](#configuring-the-response-fields) parameter. This request also supports [breadcrumbs](#configuring-the-response-breadcrumbs).

##### Basic Filters
##### Basics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-clark84 Should this still be Basic Filters for consistency with other filters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Timothy-Edwards sorry I don't think I meant to make this change. I have a feeling I inadvertently remove Filters when Ictrl+fin the doc for Filters.

Can "cancel" this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Basics
##### Basic Filters

@@ -253,6 +253,7 @@ This request supports [date_filters](#filters-date-filters) over the following f
| date_completed |
| date_modified |
| date_due |
| started |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-clark84 Looks like the started filter is already documented on line 250?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Timothy-Edwards yep date_started is on line 250, I thought your comment here was suggesting that started should be its own unique filter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not wanting to put words in Tim's mouth, but I suspect that comment was meant more as "if we are missing it from the update-able field list, we may also be missing it from the described filters list, so that might need to be added too" (and then he left off the "date_" part to confuse matters)

Suggested change
| started |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-clark84 Yeah, sorry glenn is correct. date_started is the correct format for all the date filters. My bad I should have been clearer 🤦🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants