-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _tasks.md #145
base: main
Are you sure you want to change the base?
Update _tasks.md #145
Conversation
Added | date_started | to line 565 added | started | to line 256 As per instruction in https://affinitylive.jira.com/browse/AFFINITY-35257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things from me, let me know if you need a hand with anything
@@ -223,7 +223,7 @@ This request supports the [pagination](#configuring-the-response-pagination) par | |||
##### Additional Fields and Linked Objects | |||
This request supports requesting additional fields and linked objects from the [task object](#the-task-object) using the [`_fields`](#configuring-the-response-fields) parameter. This request also supports [breadcrumbs](#configuring-the-response-breadcrumbs). | |||
|
|||
##### Basic Filters | |||
##### Basics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nick-clark84 Should this still be Basic Filters
for consistency with other filters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Timothy-Edwards sorry I don't think I meant to make this change. I have a feeling I inadvertently remove Filters when Ictrl+f
in the doc for Filters.
Can "cancel" this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
##### Basics | |
##### Basic Filters |
@@ -253,6 +253,7 @@ This request supports [date_filters](#filters-date-filters) over the following f | |||
| date_completed | | |||
| date_modified | | |||
| date_due | | |||
| started | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nick-clark84 Looks like the started filter is already documented on line 250?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Timothy-Edwards yep date_started
is on line 250, I thought your comment here was suggesting that started
should be its own unique filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not wanting to put words in Tim's mouth, but I suspect that comment was meant more as "if we are missing it from the update-able field list, we may also be missing it from the described filters list, so that might need to be added too" (and then he left off the "date_" part to confuse matters)
| started | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nick-clark84 Yeah, sorry glenn is correct. date_started
is the correct format for all the date filters. My bad I should have been clearer 🤦🏼
Added | date_started | to line 565
added | started | to line 256
As per instruction in https://affinitylive.jira.com/browse/AFFINITY-35257