Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated and old configuration #143

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Conversation

mmacai
Copy link
Collaborator

@mmacai mmacai commented Jan 15, 2019

RATE_LIMIT_ and JWT_BLACKLIST_DEFAULT_EXPIRY_HOURS are still used in code, thus kept for now.

Closes #140

@mmacai mmacai requested a review from kevinbader January 15, 2019 16:58
@mmacai mmacai force-pushed the 140-deprecated-env-vars branch from ea93efa to 2d552b0 Compare January 15, 2019 20:07
@@ -76,7 +71,6 @@ Variable            
`RATE_LIMIT_PER_IP` | DEPRECATED. If true, the remote IP is taken into account, otherwise the limits are per endpoint only. | true
`RATE_LIMIT_SWEEP_INTERVAL_MS` | DEPRECATED. Garbage collector interval. If set to zero, Garbage collector is disabled. | 5000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #144

smoke_tests/run_smoke_tests.sh Outdated Show resolved Hide resolved
smoke_tests/run_smoke_tests.sh Outdated Show resolved Hide resolved
@mmacai mmacai merged commit 83580dc into master Jan 16, 2019
@kevinbader kevinbader deleted the 140-deprecated-env-vars branch January 16, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants