Maintain a changelog file #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks, fully agree to the changes. Regarding finding out the PR number - I'd just create the PR with [WIP] in the title and if the number was incorrent just amend and force-push the branch 🕺 |
kevinbader
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CHANGELOG.mdand related ADRCHANGELOG.mdwith all recent changesmix docsshould work and generate new contentNotes
###headers and differentiate between direct changes in given sub applicatione.g.
Decided to use PR numbers/links in notes. Downside is that you have to either guess (look at most recent PR and increment that by 1) your PR number or do one more commit after PR submit. But I think it's better to be redirected to PR and see code immediately rather than be redirected to issue and go through possibly long page to find out proper PR change.