Fix flaky Cypress tests #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbader
suggested changes
Oct 1, 2019
mmacai
reviewed
Oct 1, 2019
|
As discussed out of band, I'd prefer this over the current naming: For this to work, I'd expect |
Azer0s
force-pushed
the
fix/flaky-tests
branch
from
7ebdc28 to
9e46bcf
Compare
mmacai
reviewed
Nov 6, 2019
Azer0s
force-pushed
the
fix/flaky-tests
branch
from
c50cc9d to
d12b358
Compare
Azer0s
force-pushed
the
fix/flaky-tests
branch
from
d12b358 to
9d0999d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some timing problems with Cypress while running in CI which didn't occur while running locally (probably due to the CI instance being slower than our local machines). I fixed this by using the built-in Cypress timeouts.