Env var for internal-API's port #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbader
reviewed
Feb 8, 2018
CHANGELOG.md
Outdated
| @@ -20,6 +20,8 @@ | |||
|
|
|||
| - Fixed | |||
| - [Inbound] Make presence channel respect `JWT_USER_FIELD` setting (currently hardcoded to "username") | |||
| - [Inbound] Set proper environment variable for Phoenix server `PORT_INBOUND` - [#38](https://github.com/Accenture/reactive-interaction-gateway/pull/38) | |||
| - [API] Set proper environment variable for Phoenix server `PORT_API` - [#38](https://github.com/Accenture/reactive-interaction-gateway/pull/38) | |||
There was a problem hiding this comment.
wouldn't INBOUND_PORT and API_PORT be a bit... clearer?
There was a problem hiding this comment.
True, bad habit to use prefixes style everywhere.
kevinbader
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
API_PORT=4444 INBOUND_PORT=5555 mix phx.servershould set proper portsCloses #32