Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't fire events for filtered children on Unix #414

Merged
merged 1 commit into from
May 19, 2024

Conversation

DataTriny
Copy link
Member

Should have probably been included as part of #411

We need to compare old filtered children with new filtered children in order to decide which ones were added and removed, otherwise we emit object:children-changed:remove events for nodes unknown to ATs.

@mwcampbell mwcampbell merged commit 2bcb1b6 into main May 19, 2024
10 checks passed
@mwcampbell mwcampbell deleted the unix-children-events branch May 19, 2024 11:13
@mwcampbell mwcampbell mentioned this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants