Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve how coordinates are computed on Unix #420

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

DataTriny
Copy link
Member

Orca apparently changed the way it queries for bounds. Now only the client area of a window is considered. I chose to not drop the WindowBounds::outer field because we might need it again later, and it is public.

We also now support querying coordinates in relation to a parent, a feature that I haven't seen used but could be useful when dealing with text for instance.

@mwcampbell
Copy link
Contributor

How do we know that the correct coordinate type for the BoundsChanged event is screen? I haven't been able to find a definitive answer on this. It seems wrong for today's requirements, particularly because an app running on Wayland doesn't know its screen coordinates. But, since AT-SPI itself wasn't designed for that environment, I wouldn't be surprised to learn that a coordinate type of screen really is assumed for that event.

@mwcampbell
Copy link
Contributor

If you're reasonably sure that the screen coordinate type is the correct one for the BoundsChanged event, than I'm ready to merge this.

@DataTriny
Copy link
Member Author

Good point: my initial implementation was based on tests with GTK3 as far as I remember. But in GTK4 the coordinates space seem to be the direct parent of the Component.

With that being said, neither Chromium nor Orca use it.

@DataTriny
Copy link
Member Author

I made more tests and pushed more changes as a result. I'm quite confident in this implementation now.

@mwcampbell mwcampbell merged commit fc5125e into main May 23, 2024
10 checks passed
@mwcampbell mwcampbell deleted the unix-coords branch May 23, 2024 18:02
@mwcampbell mwcampbell mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants