Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include MSI generation files #73

Merged
merged 28 commits into from
Dec 6, 2022
Merged

Include MSI generation files #73

merged 28 commits into from
Dec 6, 2022

Conversation

okynos
Copy link
Member

@okynos okynos commented Nov 29, 2022

Hello!

This PR closes #57
We have included the following:

  • Included WXS definition to create a simple FIM installer.
  • Created service.rs file to include Windows service management.
  • Included Windows service file into WXS definition.
  • Split main.rs into monitor.rs and service.rs.
  • Adapted unix and Windows to new scheme.
  • Moved workflows to Ubuntu 20.
  • Added license and initial iteration FIM logo to MSI.
  • Minor modifications into config module to include Windows config file detection.
  • Added util function to get current directory.

Regards!

@okynos
Bump Ubuntu 18 to Ubuntu 20 tests due to deprecation
6a465ee
@okynos
Partially solve config fetch problem in Windows systems
a1bd7bc
@okynos
Added first tests of MSI generation
4cf73a1
@okynos
Fixed error in windows config unit tests
74d2deb
@okynos
Added MSI file license file
bd00cd2
@okynos
Renamed win folder to msi
2d45d63
@okynos
Added customization of FIM installation, no modify flag and machine i…
53113d5 
…nstallation
@okynos
First iteration in MSI package generation with service management
1b72844
@okynos
Fixed linux compilation with service module
bd17a36
@okynos
Merge branch 'main' of github.com:Achiefs/fim into 57-provide-windows…
616cafe 
…-installer
@okynos
Fixed windows specific unit tests
aad38fc
@okynos
Clean WXS file
8a9ae2a
@okynos
Fixed cargo clippy, removed monitor from unit tests
6a9ff50
@okynos
Added Windows package build test
8708e17
@okynos
Fix syntax error in pkg workflow
edf90d8
@okynos
Added path to candle and light
3ff16de
@okynos
Added Invoke-expression call to light
6189867
@okynos
Fix WXS file path in workflow test
1215dc4
@okynos
Changed building path to pkg\msi
ee8d4c4
@okynos
Fix config copy into build process
7be147e
@okynos okynos self-assigned this Nov 29, 2022
@okynos okynos linked an issue Nov 29, 2022 that may be closed by this pull request
Define and manage a way to provide Windows installer #57
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 30, 2022
View reviewed changes
src/utils.rs Fixed Show fixed Hide fixed
alberpilot
alberpilot approved these changes Dec 6, 2022
View reviewed changes
Copy link

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@okynos okynos merged commit f28a1df into main Dec 6, 2022
@okynos okynos deleted the 57-provide-windows-installer branch December 6, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberpilot alberpilot alberpilot approved these changes

Assignees

@okynos okynos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define and manage a way to provide Windows installer
2 participants
@okynos @alberpilot