Interference Crash Fix #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastein
approved these changes
Sep 18, 2024
jxi24
added a commit
that referenced
this pull request
Sep 18, 2024
* fix: The main for NuHepMC_ccputils doesn't compile * feat: Add InspireHEP ID for intf model * fix: Correctly select spectator particles * fix: Have correct event history vertex count
jxi24
added a commit
that referenced
this pull request
Sep 27, 2024
* feat(WIP): Implement pseudocode for abs * feat: Begin refactoring for pion absorption * fix: Rename status code * feat: Add wrapper around Pion cascade handling * Generate momentum and cross section now take Event and hadron indices. Also added absorption partner * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Filled in details of one step absorption model. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added Oset absorption cross section * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Update to lastest NuHepMC * feat: Add suggested option if misspelt * fix: Minor logic update in FindClosest * fix: Update tests after changes to InteractionHandler * feat: Add tests for suggestions * fix: Make edits more expensive for suggestions * Add start for handling different final states in abs * fix: Resolve cascade speed bug * refactor: Reorganize cascade interactions * Merging speed improvements * Fixed std::string bug * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed bug in PionInteractions, updated GenMomentum * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * PionAbsorptionOneStep now uses same gen momentum as mesonbaryoninteractions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Set nuclear radius to when rho < 1e-6, would sometimes give negative densities * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Resolve Pauli blocking bug * Added Oset QE Interactions and fixed bugs in gen momentum for both oset QE and Abs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: Implement ClebschGordan coefficients * fix: Update 1D integrators to Achilles namespace * feat: Add N(1440) to particles * feat: Implement NN<->NDelta based on GiBUU model * Fixed bug in Adzint, use correct delta momentum in absorption xsec * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Cast to right type * fix: Change step to be in time instead of MeV^-1 * feat: Add basic handling for decays * feat: Add basic decays to cascade * fix: compliation issue * fix: Rename decays file * feat: Add isospin to particles * fix: Correct branching ratios and delta- * feat: Add branching ratio lookup * feat: Implement basic delta propagation model NOTE: This is slow since it involves quite a few integrals. There is the start to using some interpolation methods to speed this up in this commit. These will be improved in the near future. * Added separate proton and neutron densities to nucleus class * Oset cross sections now use total density (p + n), also turned back on PB for oset abs cross section * Make eta stable, no decay info yet * Updated to include neutron density file * Use delta mode to fix bug * Remove eroneous factor of two in self energy calcs for delta prop * Turn on PB for Oset absorption model * Interference Crash Fix (#72) * fix: The main for NuHepMC_ccputils doesn't compile * feat: Add InspireHEP ID for intf model * fix: Correctly select spectator particles * fix: Have correct event history vertex count * feat: Update fmt version * fix: Ensure unstable particles are decayed * fix: Make Particle constructor explicit * feat: Add check is particle is delta * feat: Add missing delta channels * fix: Resolve initialization issues for DEintegrator * feat: Print decay modes for debugging * fix: Enable tests to compile * fix: Correct Pauli blocking bug * fix: Check if interaction is above threshold * eta-N interactions now work with MB + PionAbsorption * Added pi0 decay to 2gamma, and made pi0 unstable * Updated default run card * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Resolve broken CI --------- Co-authored-by: Noah Steinberg <nastein@umich.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71