Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split classes in their own file #124

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

TristanPouliquen
Copy link
Contributor

Some classes were stored in the same file, not following PSR4 conventions.

This prevented tools such as PHPStan to easily discover these symbols & read these classes.

Moving them to different files does not cause a breaking change as the namespace does not change.

@TristanPouliquen
Copy link
Contributor Author

If needed, models could be rearranged in sub-folders, using https://www.schmengler-se.de/en/2016/09/php-using-class_alias-to-maintain-bc-while-move-rename-classes/ to avoid BC breaks.

@ewood-ac ewood-ac merged commit ecacd3c into ActiveCampaign:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants