Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-5950 migrate to OAS3 #494

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

Giovanni007
Copy link
Contributor

@Giovanni007 Giovanni007 commented Oct 21, 2021

Ref: 3743 Update of the Springfox configuration and swagger-core annotation to support OAS3

OAS3 doesn't support '<< ' in the module names so replacing them using "Of"
OAS3.0.3 doesn't support request body for DELETE method ( eg. rb specifications will show an error generates an error if trying to validate it on swagger-editor) but the support will be back with OAS3.1 (see PR)

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2021

CLA assistant check
All committers have signed the CLA.

@Giovanni007 Giovanni007 marked this pull request as ready for review October 25, 2021 09:42
@Giovanni007 Giovanni007 changed the title AAE-5950 migrate to openapi3 AAE-5950 migrate to OAS3 Oct 25, 2021
Copy link
Contributor

@miguelruizdev miguelruizdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@balsarori balsarori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Giovanni007 Giovanni007 force-pushed the dev-gfertuso-AAE-5950-migrate-to-openapi3 branch from 2737ae0 to 452dbb7 Compare October 26, 2021 11:45
@Giovanni007 Giovanni007 merged commit 5cc7a9c into develop Oct 26, 2021
@Giovanni007 Giovanni007 deleted the dev-gfertuso-AAE-5950-migrate-to-openapi3 branch October 26, 2021 12:45
balsarori pushed a commit that referenced this pull request Mar 6, 2023
…cies to 7.1.743 (#494)

Co-authored-by: Alfresco Build <alfresco-build-user@users.noreply.github.com>
wojciech-piotrowiak pushed a commit that referenced this pull request Dec 14, 2023
* Update spingfox configuration to use OpenAPi3

* Update tests

* upgrade swagger-annotations  replacing swagger2 with OAS3 annotations

* use the "Of" convetion instead of Generics types in Swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants