-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Type Optimization #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial review, there's a lot to go through here and I'm not done but want to share my comments so far instead of holding them all until I'm done.
activitysim/abm/models/util/test/test_mandatory_tour_frequency.py
Outdated
Show resolved
Hide resolved
activitysim/examples/placeholder_psrc/configs/stop_frequency_annotate_tours_preprocessor.csv
Show resolved
Hide resolved
@jpn-- I'm gonna remove these files. I used them to write out the memory of each column in the interaction_df. It was useful when I did the diagnosis, but probably not needed in actual implementation.
…e-dev-merge # Conflicts: # activitysim/core/util.py
relax progressive checks for categorical dtypes
…e-dev-merge # Conflicts: # activitysim/core/interaction_simulate.py
Merge Develop Branch
@jpn-- seems the change of the black version has caused the linting test to fail. I can update my local black and reformat if you are ok with that. |
No, I made a mistake and clicked the wrong button to merge code into develop I wasn't intending to. I rolled it back, should be better if you just merge in the latest changes from the develop branch. |
Bring in the latest Develop
# Conflicts: # activitysim/abm/models/vehicle_type_choice.py
latest updates from other PRs
PR for #673