Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Type Optimization #782

Merged
merged 50 commits into from
Feb 13, 2024
Merged

Conversation

i-am-sijia
Copy link
Contributor

PR for #673

@i-am-sijia i-am-sijia added the Performance Changes that improve performance label Dec 28, 2023
Copy link
Member

@jpn-- jpn-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a partial review, there's a lot to go through here and I'm not done but want to share my comments so far instead of holding them all until I'm done.

activitysim/core/util.py Show resolved Hide resolved
activitysim/core/util.py Outdated Show resolved Hide resolved
activitysim/abm/models/vehicle_type_choice.py Outdated Show resolved Hide resolved
activitysim/core/util.py Show resolved Hide resolved
@jpn-- jpn-- self-assigned this Jan 30, 2024
@dhensle dhensle added the Phase 8 Feature planned for inclusion in Phase 8 release label Jan 30, 2024
@i-am-sijia
Copy link
Contributor Author

@jpn-- seems the change of the black version has caused the linting test to fail. I can update my local black and reformat if you are ok with that.

@jpn--
Copy link
Member

jpn-- commented Feb 6, 2024

@jpn-- seems the change of the black version has caused the linting test to fail. I can update my local black and reformat if you are ok with that.

No, I made a mistake and clicked the wrong button to merge code into develop I wasn't intending to. I rolled it back, should be better if you just merge in the latest changes from the develop branch.

i-am-sijia and others added 2 commits February 6, 2024 23:09
Bring in the latest Develop
# Conflicts:
#	activitysim/abm/models/vehicle_type_choice.py
@jpn-- jpn-- merged commit 1f42cd3 into ActivitySim:develop Feb 13, 2024
1 check passed
@jpn-- jpn-- mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Changes that improve performance Phase 8 Feature planned for inclusion in Phase 8 release
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants