Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dist): fix codesigning & verious improvements #702

Conversation

kewde
Copy link
Contributor

@kewde kewde commented Jan 5, 2022

Various fixes

  • $APPLE_PERSONAL_ID is the hash identifier of the certificate of the person signing, for personal accounts this is the same as $APPLE_TEAM_ID. There is reason to split these two for organisations though, so let's do this early on 😄
  • The certificate being installed on the CI should have the identifier $APPLE_PERSONAL_ID, use that id instead of hardcoding ActivityWatch as the signer for the dmg.
  • Moved the installation of the certificate to the CI scripts, out of the makefile
  • Do not deep sign the dmg

cc @ErikBjare

@kewde kewde changed the title fix(dist): fix codesigning & make difference between fix(dist): fix codesigning & verious improvements Jan 5, 2022
Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just a nitpick and a question.

I also want to take this opportunity to thank you for engaging with this long-standing and thorny issue (and a constant nag on me, since users often face related issues).

Since there's a bounty on getting this issue resolved, I also want to communicate my intent to award you a meaningful part (~half) of the $1,000 bounty once it hits master :)

.github/workflows/build.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
aw.spec Outdated Show resolved Hide resolved
scripts/notarize.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ErikBjare ErikBjare merged commit e62f483 into ActivityWatch:dev/macos-sign-and-notarize Jan 5, 2022
@kewde
Copy link
Contributor Author

kewde commented Jan 5, 2022

@ErikBjare You can keep the amount yourself or put it up for another bounty:

  • persist settings across browsers & sessions
  • fix the negative timestamps on LockApp.exe (happens when going into sleep on WIndows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants