Remove upper version requirement on Python #106
Conversation
aw-qt fails to build on Fedora 41, because it requires Python < 3.13 and Fedora uses Python 3.13. It works fine with the latest version of Python though. This patch is intended to help with Fedora packaging by assuming that aw-qt works on the latest Python instead of requiring the packager to test it manually with every major release of Python.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 37540bc in 28 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_bKxw6cS7bv8oZ3q9
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -13,7 +13,7 @@ packages = [ | |||
| aw-qt = "aw_qt:main" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.8,<3.13" | |||
| python = "^3.8" | |||
There was a problem hiding this comment.
Removing the upper version constraint on Python (<3.13) is a significant change. While it resolves the immediate compatibility issue with Fedora 41, it could lead to unforeseen issues with future Python versions. Consider specifying a more conservative upper limit, like <3.14 or <3.15, to safeguard against potential breaking changes in new Python versions until they can be properly tested.
| python = "^3.8" | |
| python = "^3.8,<3.15" |
|
ping |
|
I'm not sure why the constraint was added in the first place, but I suppose it is possible it is no longer needed. Merging. |
aw-qt fails to build on Fedora 41, because it requires Python < 3.13 and Fedora uses Python 3.13. It works fine with the latest version of Python though.
This patch is intended to help with Fedora packaging by assuming that aw-qt works on the latest Python instead of requiring the packager to test it manually with every major release of Python.
Summary:
Removed the upper version limit on Python in
pyproject.tomlto support Python 3.13 and future versions.Key points:
pyproject.tomlto remove the upper version limit on Python.pythondependency from^3.8,<3.13to^3.8.Generated with ❤️ by ellipsis.dev