-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Chronological timeline visualization #380
feat: Chronological timeline visualization #380
Conversation
ShootingKing-AM
commented
Oct 26, 2022
- Shows chronological events on a timeline for currentDay ± 1day from all (non-empty) buckets.
- For now, does not support greater timeperiod than 'day'
- Automatically updates the data with date-period change
- To add this Visualization, Activity page -> "Edit View" -> "Add Visualization". Click on the Visualization's Settings (⚙) -> "Daily Timeline"
- PR Also fixes large visualizations not being displaced as col-lg-12
- Also fixes large visualizations not being displaced as col-lg-12
Codecov ReportBase: 25.35% // Head: 25.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 25.35% 25.05% -0.31%
==========================================
Files 26 27 +1
Lines 1471 1489 +18
Branches 235 240 +5
==========================================
Hits 373 373
- Misses 1068 1086 +18
Partials 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Erik, was not able to get data from fullDesktopQueries itself :( because,
This PR seems a lot more cleaner, maintainer-friendly(D:) implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat little PR, love the component reuse! 🌟
Just have some performance concerns.
Going to ahead and merge this, will test it next week :) Thanks for the contribution @ShootingKing-AM! ❤️ |
Thanks for the very quick review and merge :3 |