Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Chronological timeline visualization #380

Merged

Conversation

ShootingKing-AM
Copy link
Contributor

  • Shows chronological events on a timeline for currentDay ± 1day from all (non-empty) buckets.
  • For now, does not support greater timeperiod than 'day'
  • Automatically updates the data with date-period change
  • To add this Visualization, Activity page -> "Edit View" -> "Add Visualization". Click on the Visualization's Settings (⚙) -> "Daily Timeline"
  • PR Also fixes large visualizations not being displaced as col-lg-12

image

- Also fixes large visualizations not being displaced as col-lg-12
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 25.35% // Head: 25.05% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (9a12766) compared to base (27e5c59).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   25.35%   25.05%   -0.31%     
==========================================
  Files          26       27       +1     
  Lines        1471     1489      +18     
  Branches      235      240       +5     
==========================================
  Hits          373      373              
- Misses       1068     1086      +18     
  Partials       30       30              
Impacted Files Coverage Δ
src/util/classes.ts 81.18% <0.00%> (-1.65%) ⬇️
src/stores/categories.ts 55.55% <0.00%> (-1.59%) ⬇️
src/util/validate.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ShootingKing-AM
Copy link
Contributor Author

ShootingKing-AM commented Oct 26, 2022

Erik, was not able to get data from fullDesktopQueries itself :( because,

  • had to get current day +- 1 day events, else it seems abrupt while using day-to-day basis
  • had to get all buckets
  • getting events, have to package them so that VisTimeline can consume it
  • its getting messier

This PR seems a lot more cleaner, maintainer-friendly(D:) implementation

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat little PR, love the component reuse! 🌟

Just have some performance concerns.

src/components/SelectableVisualization.vue Outdated Show resolved Hide resolved
@ShootingKing-AM ShootingKing-AM marked this pull request as draft October 26, 2022 19:32
@ShootingKing-AM ShootingKing-AM marked this pull request as ready for review October 28, 2022 01:23
@ErikBjare
Copy link
Member

Going to ahead and merge this, will test it next week :)

Thanks for the contribution @ShootingKing-AM! ❤️

@ErikBjare ErikBjare merged commit d96471c into ActivityWatch:master Oct 28, 2022
@ShootingKing-AM
Copy link
Contributor Author

Thanks for the very quick review and merge :3

@ShootingKing-AM ShootingKing-AM deleted the feat-vis-timeline-activity branch November 20, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants