Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update github actions #632

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Feb 12, 2025

Important

Update GitHub Actions to use actions/upload-artifact@v4 and modify log artifact naming in nodejs.yml.

  • GitHub Actions:
    • Update actions/upload-artifact from v3.1.2 to v4 in build-webpack, build-vite, and test jobs in nodejs.yml.
    • Change log artifact name to logs-${{ matrix.aw-server }}-${{ matrix.aw-version }} in test job.

This description was created by Ellipsis for 241f9cf. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 359f0b6 in 34 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. .github/workflows/nodejs.yml:32
  • Draft comment:
    Ensure v4 of upload-artifact retains the same input schema (e.g., using 'path') as v3.1.2. Consult the v4 docs for any parameter changes.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
2. .github/workflows/nodejs.yml:60
  • Draft comment:
    Verify that the v4 action behaves identically for the vite build job, particularly confirming parameters like 'path' remain supported.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
3. .github/workflows/nodejs.yml:194
  • Draft comment:
    Double-check that v4 is fully backward compatible for uploading logs artifacts and that no breaking changes affect the 'with' configuration.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
4. .github/workflows/nodejs.yml:33
  • Draft comment:
    Updated to upload-artifact v4. Verify that all current input parameters (name, path) remain valid with v4.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. .github/workflows/nodejs.yml:61
  • Draft comment:
    Ensure artifact upload for build-vite works as expected with the new v4 action version.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
6. .github/workflows/nodejs.yml:195
  • Draft comment:
    Confirm that the log upload step functions correctly under the new v4 upload-artifact action.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_J2qd66o4r08wYLB5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.98%. Comparing base (291da6f) to head (241f9cf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files          27       27           
  Lines        1643     1643           
  Branches      279      292   +13     
=======================================
  Hits          427      427           
+ Misses       1190     1157   -33     
- Partials       26       59   +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BelKed BelKed changed the title fix: update upload-artifact action to version 4 fix: update github actions Feb 12, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 241f9cf in 55 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. .github/workflows/nodejs.yml:33
  • Draft comment:
    Ensure v4 of upload-artifact is compatible with your workflow. Check breaking changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure compatibility and check for breaking changes, which falls under the rule of not asking the author to confirm or ensure things. It doesn't provide a specific suggestion or point out a specific issue.
2. .github/workflows/nodejs.yml:61
  • Draft comment:
    Confirm upload-artifact v4 usage in build-vite matches expected inputs.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to confirm that the usage of 'upload-artifact v4' in 'build-vite' matches expected inputs. This falls under asking the author to confirm their intention or to double-check things, which is against the rules.
3. .github/workflows/nodejs.yml:195
  • Draft comment:
    Artifact name change for logs is clearer, verify downstream consumers expect new naming.
  • Reason this comment was not posted:
    Confidence changes required: 40% <= threshold 50%
    None
4. .github/workflows/nodejs.yml:32
  • Draft comment:
    Changed 'actions/upload-artifact' from v3.1.2 to v4 in the build-webpack job. Consider pinning to a specific minor version for reproducibility.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. .github/workflows/nodejs.yml:61
  • Draft comment:
    Upgraded 'actions/upload-artifact' to v4 in the build-vite job. Verify that no breaking changes affect artifact handling and consider pinning the version.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
6. .github/workflows/nodejs.yml:195
  • Draft comment:
    Modified the logs upload step: updated to v4 and changed the artifact name to include matrix variables. Ensure downstream processes expect the new dynamic naming.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_C2YWMUYx7h32lLi1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant