Fix association building for belongs_to with :with_deleted option #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
issue-232-fix-association-building
branch
2 times, most recently
from
f80f668 to
5d0858a
Compare
mvz
force-pushed
the
issue-232-fix-association-building
branch
from
5d0858a to
21c2281
Compare
…eleted Normally, ActiveRecord's AssociationReflection does not allow automatic calculation of the inverse relation if the inverse reflection has a scope. This adds an override to AssociationReflection that special-cases reflections that have a scope that was added _only_ to support the :with_deleted option.
mvz
force-pushed
the
issue-232-fix-association-building
branch
from
98a8041 to
88cc53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override of
belongs_tocreates a scope in the association where normally there would be none if the:with_deletedoption is given. Having a scope in an association makes ActiveRecord refuse to automatically find an inverse relation. This change adds an override to make an exception if the scope was only added to support the:with_deletedoption.Fixes #232.