-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove activesupport
from explicit dependencies
#346
base: master
Are you sure you want to change the base?
Remove activesupport
from explicit dependencies
#346
Conversation
56ef6cf
to
6434ac5
Compare
The reason there's a direct dependency is that the code directly accesses the ActiveSupport namespace. That's mostly a question of esthetics, but activerecord does the same since it depends on both activemodel and activesupport, whereas activemodel also depends on activesupport.
I've been trying this out and I can see this happening (in my case, it updates minitest via activesupport), but removing the direct dependency on activesupport makes no difference. Do you have some demonstration that this change will actually have the effect you're looking for? |
Don't know how to locally demonstrate it without releasing a new version with this change. I was pretty sure this is the case. |
Would this have any impact on enabling my project to upgrade to Rails 8?
|
@pas256 no, the activerecord dependency also won't allow Rails 8. |
@mvz when are we planning to support rails 8? acts_as_paranoid is the only gem stopping me from upgrading to Rails 8 |
I'll probably make a release this weekend. |
@rajneeshsharma9 Version 0.10.3 supporting Rails 8.0 has now been released. |
activerecord
already depends onactivesupport
.Moreover, when trying to upgrade the gem without
--conservative
option, it tries to also upgradeactivesupport
dependencies, which is not needed.