Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

Merge AI and Master branches #43

Merged
merged 22 commits into from
Apr 11, 2019
Merged

Merge AI and Master branches #43

merged 22 commits into from
Apr 11, 2019

Conversation

nzlz
Copy link
Contributor

@nzlz nzlz commented Apr 10, 2019

The goal of this PR is that everyone at Acutronic Robotics ends up using the same branch, master.

The main differences with AI branch:

  • We still use cognition. Since we are the only ones using it, we should be able to push our changes here. We are using the correct topic naming convention. (The reason behing still depending on cognition is that rclpy multiple callbacks are turning to be more inconsistent in terms of speed: ROS Answers.
  • We need custom URDFs. The training plugin is different form the real one, so must be called differently from the URDF. We also need a visual blue point in the middle of the gripper to visually observe the accuracy of the learnt policy. @YueErro Can you take care of creating xacro files for the new urdfs inside /urdf/reinforcement_learning? Could this be dependent on the base mara+140 gripper xacro file somehow?
  • We use a different plugin for training. This plugin is optimized for fast training, still lot of room for improvement. But important thing here is we do not change anything, only add a new plugin to the list.
  • New spawner script with input arg. mara_utils_scripts/scripts/spawn_mara_arg.py takes the urdf path as input argument, which avoids having the need to create a new spawn-script for each urdf. The usage in a ROS2 LaunchDescription object is the following:
    Node(package='mara_utils_scripts', node_executable='spawn_mara_arg.py', arguments=["reinforcement_learning/mara_robot_gripper_140_train.urdf"], output='screen')```
  • Removed warnings from the mara_gazebo_joint_plugin.
  • Changed gazebo_ros_pkgs branch. Update the branch to acutronicrobotics/gazebo_ros_pkgs (ros2_gym-gazebo2), which is the same as crystal but with the properties plugin included.

Concerns

The run plugin (mara_gazebo_joint_plugin) used to be smoother in the end of the execution. This could be due to the fact that we are trying a policy learnt in different urdfs, needs testing.

Please share your thoughts.

@nzlz
Copy link
Contributor Author

nzlz commented Apr 10, 2019

Update. The run driver is doing fine, the bad policy execution was caused by a bug in the environment. Not related to this PR.

Copy link
Contributor

@LanderU LanderU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments please

@rkojcev rkojcev requested review from rkojcev and LanderU April 10, 2019 12:16
Copy link
Contributor

@rkojcev rkojcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorrecioh and @carlossvg please check if this breaks anything for you. Otherwise LGTM

@LanderU
Copy link
Contributor

LanderU commented Apr 10, 2019

LGTM!

nzlz and others added 4 commits April 11, 2019 09:40
@rkojcev rkojcev merged commit a6eaeb6 into master Apr 11, 2019
@YueErro YueErro deleted the ai_v2 branch April 17, 2019 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants