This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Merge AI and Master branches #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkojcev
approved these changes
Apr 10, 2019
Update. The run driver is doing fine, the bad policy execution was caused by a bug in the environment. Not related to this PR. |
LanderU
reviewed
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comments please
mara_gazebo_plugins/include/mara_gazebo_plugins/mara_gazebo_joint_plugin.hpp
Show resolved
Hide resolved
rkojcev
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igorrecioh and @carlossvg please check if this breaks anything for you. Otherwise LGTM
LanderU
approved these changes
Apr 10, 2019
LGTM! |
without the robot_base and, with/without camera + train and run plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is that everyone at Acutronic Robotics ends up using the same branch,
master
.The main differences with AI branch:
crystal
but with the properties plugin included.Concerns
The run plugin (mara_gazebo_joint_plugin) used to be smoother in the end of the execution. This could be due to the fact that we are trying a policy learnt in different urdfs, needs testing.
Please share your thoughts.