Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Julia Bouvier #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

juliabouv
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? Overall, my indentation should match the ruby formatting guidelines. I also included many comments to increase the readability of the code. I had some trouble coming up with descriptive variable names without becoming repetitive.
How did your code keep track of user input? I used regex to verify user input when getting the two numbers. To verify the user input for choice of operation, if the user did not enter one of the applicable strings, the case/when conditional would print a unique message in the else.
How did your code determine what operation to perform? My code used a case/when conditional to pass the appropriate arguments into the defined method when it matches the user input.
What opportunities exist to create small methods for this project? I used one large method to encapsulate all of the different math operations. However, a method could also be used for each individual math operation. Or, one method could include a conditional to calculate the applicable operation per user input. A method could also be used for the user input verification.
In the next project, what would you change about your process? What would you keep doing? I would write more pseudocode to more effectively write my code. More structuring ahead of time would have saved me time overall.

@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately X
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

Great work! Glad Mira was able to use that "send" method to get the calculate method working like you were going for! And I'm glad to hear that you expect pseudocode to be helpful in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants