Scissors - Maria M. #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
Apr 1, 2021
| @@ -1,7 +1,7 @@ | |||
| import pytest | |||
| from viewing_party.main import * | |||
|
|
|||
|
|
|||
| """ | |||
There was a problem hiding this comment.
I'm curious why you have these tests commented out. They seem to pass when I uncomment them
| watched_list = user_data["watched"] | ||
| for movie in watched_list: | ||
| for movie_val in movie.values(): | ||
| if type(movie_val) == float: |
There was a problem hiding this comment.
I'm curious why this line was added. It seems like it might be more appropriate for the function to add numbers even if they aren't float type.
| for movie_dict in user_watched_list: | ||
| for movie, movie_title in movie_dict.items(): | ||
| user_titles.append(movie_title) | ||
| print(user_titles) |
There was a problem hiding this comment.
Its generally best to remove print statements like this that aren't required before committing and/or submitting
| print(u_unique_dict_list) | ||
| return u_unique_dict_list | ||
|
|
||
| def find_user_diff(unique_list, comp_list): |
There was a problem hiding this comment.
Love that you made your own custom helper function!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.