Paper : Karla #70
Open
Paper : Karla #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk box with dynmaic nature background. Up next: cont css adjustments and add javascript funtionality.
…re, a clickable element to increase/decrease temperature and an elementthat displays a landscape.
…entbyID was added still needs adjustments for JS to work.
…lect with change for eventlistener and removed search option. Next will begin wave 4.
… to drop editable and used a input type text instead. Reset button atm resets the city text box to a blank box.
CheezItMan
reviewed
Jun 24, 2021
Comment on lines
+2
to
+7
| let btnAdd = document.getElementById('add'); | ||
| let btnSubtract = document.getElementById('subtract'); | ||
| let tempInput = document.getElementById('temp_id'); | ||
| let landscape = document.getElementById('landscape'); | ||
| let skiesInput = document.getElementById('sky-select'); | ||
| let skiesLandscape = document.getElementById('sky-landscape'); |
There was a problem hiding this comment.
Not a bad idea having these at the top, but it's possible the HTML might get loaded by the browser AFTER the JS. So in that case these variables would be set to undefined.
Also why not make them const?
Comment on lines
+13
to
+19
| function countUp(element) { | ||
| element.value = parseInt(element.value) + 1; | ||
| } | ||
|
|
||
| function countDown(element) { | ||
| element.value = parseInt(element.value) - 1; | ||
| } |
Comment on lines
+22
to
+32
| if (tempInput.value >= 80) { | ||
| tempInput.style.color = 'red'; | ||
| } else if (tempInput.value >= 70 && tempInput.value <= 79) { | ||
| tempInput.style.color = 'orange'; | ||
| } else if (tempInput.value >= 60 && tempInput.value <= 69) { | ||
| tempInput.style.color = 'yellow'; | ||
| } else if (tempInput.value >= 50 && tempInput.value <= 59) { | ||
| tempInput.style.color = 'green'; | ||
| } else if (tempInput.value <= 49) { | ||
| tempInput.style.color = 'teal'; | ||
| } |
There was a problem hiding this comment.
In general don't set styles directly, instead set the element's class name. Otherwise you're mixing roles between the behavior (JS) and presentation (CSS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.