Fix conditional dependency on dataclasses (pvlib#1422)

* better conditional dependency on dataclasses * whatsnew
AdamRJensen · Mar 17, 2022 · e3baa12 · e3baa12
1 parent 27cba7a
commit e3baa12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst
@@ -64,6 +64,8 @@ Documentation
 Requirements
 ~~~~~~~~~~~~
 * numpy >= 1.16.0 is now required for all python versions. (:pull:`1400`)
+* Fix an installation issue with ``dataclasses`` on python 3.6
+  (:issue:`1302`, :pull:`1422`)
 
 
 Contributors

diff --git a/setup.py b/setup.py
@@ -43,11 +43,8 @@
                     'pytz',
                     'requests',
                     'scipy >= 1.2.0',
-                    'h5py']
-
-# include dataclasses as a dependency only on python 3.6
-if sys.version_info.major == 3 and sys.version_info.minor == 6:
-    INSTALL_REQUIRES.append('dataclasses')
+                    'h5py',
+                    'dataclasses; python_version < "3.7"']
 
 TESTS_REQUIRE = ['nose', 'pytest', 'pytest-cov', 'pytest-mock',
                  'requests-mock', 'pytest-timeout', 'pytest-rerunfailures',