Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytorch Tutorial 5 - MNIST classification - Jupyter and Markdown #91

Merged
merged 8 commits into from
Oct 21, 2021
Merged

Pytorch Tutorial 5 - MNIST classification - Jupyter and Markdown #91

merged 8 commits into from
Oct 21, 2021

Conversation

Adamage
Copy link
Owner

@Adamage Adamage commented Oct 5, 2021

Summary

I split all the functions used in the __main__ because the main program and argument parsing have been removed.

Now the structure is linear and follows naturally from what has to be done - datasets loading, training, evaluating.

Added descriptions to steps and links to more documentation.

Changed a bit how TDQM is used.

@Adamage
Copy link
Owner Author

Adamage commented Oct 5, 2021

Closing #66

@Adamage Adamage self-assigned this Oct 5, 2021
@Adamage Adamage changed the title Pytorch Tutorial 5 - MNIST classification Pytorch Tutorial 5 - MNIST classification - Jupyter and Markdown Oct 5, 2021
@plutasnyy plutasnyy linked an issue Oct 6, 2021 that may be closed by this pull request
Tutorial 5 - PyTorch Mnist #66
Closed
@plutasnyy
Copy link
Collaborator

I think you got the wrong folder, tutorial 5 is in tutorials/simple_applications/pytorch/mnist/ ;)

plutasnyy
plutasnyy reviewed Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@plutasnyy plutasnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice to read ;)

tutorials/pytorch/tut5_mnist/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut5_mnist/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut5_mnist/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut5_mnist/README.md Outdated Show resolved Hide resolved
arbfay
arbfay suggested changes Oct 13, 2021
View reviewed changes
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
@Adamage
Copy link
Owner Author

Adamage commented Oct 14, 2021

@LRVerkin @arbfay I pushed the fixes please check the updated descriptions, new links, removed softmax layer.

dirkbrink
dirkbrink suggested changes Oct 15, 2021
View reviewed changes
simple_applications/pytorch/mnist/README.md Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/mnist_poptorch.py Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Show resolved Hide resolved
@Adamage
Copy link
Owner Author

Adamage commented Oct 18, 2021 •
edited
Loading

TODO to self:

  • use AnchorMode to calculate accuracy and loss better (or allow a switch to enable this or not - poptorch.AnchorMode.All or poptorch.AnchorMode.Sum

Pytorch tutorial 5 - review fixes - add AnchorMode to show predictabl…
36332ac 
…e behavior of training statistics like previewing losses and accuracy
dirkbrink
dirkbrink suggested changes Oct 19, 2021
View reviewed changes
Copy link

@dirkbrink dirkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition with the anchor stuff

simple_applications/pytorch/mnist/README.md Outdated Show resolved Hide resolved
simple_applications/pytorch/mnist/README.md Show resolved Hide resolved
@Adamage
Copy link
Owner Author

Adamage commented Oct 19, 2021

@dirkbrink @LRVerkin Thank you guys for the comments. I pushed changes addressing those requests, please check

dirkbrink
dirkbrink approved these changes Oct 20, 2021
View reviewed changes
Copy link

@dirkbrink dirkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming Louise is also happy

@LRVerkin
Copy link
Collaborator

LGTM as well

@Adamage Adamage merged commit c7f7558 into main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plutasnyy plutasnyy plutasnyy left review comments

@LRVerkin LRVerkin LRVerkin left review comments

@arbfay arbfay arbfay requested changes

@dirkbrink dirkbrink dirkbrink approved these changes

Assignees

@Adamage Adamage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial 5 - PyTorch Mnist
5 participants
@Adamage @plutasnyy @LRVerkin @arbfay @dirkbrink