Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): added ellipsis for long chat names #534

Merged

Conversation

juliahermak
Copy link
Member

@juliahermak juliahermak commented Oct 3, 2023

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 10:27pm

@bludnic
Copy link
Member

bludnic commented Oct 4, 2023

@adamant-al
Copy link
Member

Much space is unused.
It's better to calculate margin-right depending on date field width.

image

@bludnic
Copy link
Member

bludnic commented Oct 4, 2023

Much space is unused. It's better to calculate margin-right depending on date field width.

image

I think it is not possible to achieve this with plain CSS. Let's keep it simple and find the optimal margin-right (less possible value to not overflow the date).

@martiliones
Copy link
Collaborator

I think it is not possible to achieve this with plain CSS. Let's keep it simple and find the optimal margin-right (less possible value to not overflow the date).

can we use display: flex instead of absolute positioning so we could set margin-left to date instead?

@bludnic
Copy link
Member

bludnic commented Oct 4, 2023

I think it is not possible to achieve this with plain CSS. Let's keep it simple and find the optimal margin-right (less possible value to not overflow the date).

can we use display: flex instead of absolute positioning so we could set margin-left to date instead?

It's worth a try, but it requires changing the markup structure, because the chat name and the date are not placed in the same div.

@bludnic
Copy link
Member

bludnic commented Oct 4, 2023

@juliahermak Fix the date position. Compare with the version on msg.adamant.im

date-position-bug.mov

@juliahermak
Copy link
Member Author

@bludnic fixed

Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/components/ChatPreview.vue Outdated Show resolved Hide resolved
@adamant-al
Copy link
Member

@martiliones I want to see the deployment build to see how it looks like.
It seems the build is failed.

@martiliones
Copy link
Collaborator

martiliones commented Oct 6, 2023

@adamant-al
vercel hadn't triggered by my commit and it seems like github actions is broken by now (see failures above)

@bludnic how do we force vercel to redeploy?

@martiliones
Copy link
Collaborator

martiliones commented Oct 6, 2023

@adamant-al vercel actually deployed the commit but didn't show it

https://adamant-8mccwsuyo-adamant-team.vercel.app/

see https://github.com/Adamant-im/adamant-im/deployments (surge's one is failed)

Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, both on Chrome and Firefox.

Merge it.

@bludnic bludnic merged commit cc43c06 into Adamant-im:dev Oct 6, 2023
2 of 3 checks passed
@juliahermak juliahermak deleted the fix/chat-name-width-overflow-ellipsis branch October 11, 2023 02:37
@bludnic bludnic mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants