Feat/ scroll to bottom fab new messages counter #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bludnic
requested changes
Oct 4, 2023
|
Doesn't work and style bugs. |
|
@adamant-al Try to keep the tab hidden until you receive a new message (wait for the sound). This should work. The counter is not displayed because the tab is visible, so the new message is marked automatically as read regardless of the scroll position. This may be a bug. |
|
To test a feature I prefer the bug fix in this PR. |
|
@adamant-al Bug fixed. Check now |
|
The style (padding) bug is still there. 
|
|
@adamant-al Bug fixed. Check now |
adamant-al
approved these changes
Oct 10, 2023
|
@bludnic @martiliones |
martiliones
approved these changes
Oct 10, 2023
bludnic
approved these changes
Oct 10, 2023
juliahermak
deleted the
feat/-scroll-to-bottom-fab-new-messages-counter
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
https://trello.com/c/czApsWrP/216-feat-show-new-messages-count-in-chat-view-fab