Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New healthcheck #547

Merged
merged 52 commits into from
Nov 11, 2023
Merged

New healthcheck #547

merged 52 commits into from
Nov 11, 2023

Conversation

bludnic
Copy link
Member

@bludnic bludnic commented Nov 1, 2023 •
edited
Loading

  • Added unified Healthcheck for all nodes (ADM, BTC, ETH, DOGE, DASH, LSK)
  • Show additional info for "Unsupported status": Http is not allowed, Outdated API version, Not reachable

image

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 2:34pm

@bludnic bludnic marked this pull request as draft November 1, 2023 16:24
@bludnic bludnic temporarily deployed to testing November 1, 2023 16:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Deployed to https://msg-adamant-pr-547.surge.sh 🚀

@bludnic bludnic temporarily deployed to testing November 2, 2023 00:07 — with GitHub Actions Inactive
@bludnic bludnic mentioned this pull request Nov 2, 2023
Merged
@bludnic bludnic marked this pull request as ready for review November 2, 2023 01:43
@bludnic bludnic temporarily deployed to testing November 2, 2023 05:24 — with GitHub Actions Inactive
@bludnic
Merge branch 'dev' into feat/new-healthcheck
5db1350 
# Conflicts:
#	src/lib/bitcoin/bitcoin-api.js
#	src/lib/bitcoin/btc-base-api.js
#	src/lib/bitcoin/dash-api.js
#	src/lib/bitcoin/doge-api.js
@bludnic
Copy link
Member Author

bludnic commented Nov 9, 2023

image
image

@bludnic
Copy link
Member Author

bludnic commented Nov 9, 2023 •
edited
Loading

  • Made NodesTable reusable. Decomposed into smaller components
  • Split NodesTable into AdmNodesTable and CoinNodesTable
  • Added label (suffix) to the Node instance
  • Added tabs to switch between ADM nodes and Coin nodes
  • Display node's height
  • Hide node version for Coin nodes (need to study coin nodes API, will be added back in the next release)

@bludnic
Copy link
Member Author

bludnic commented Nov 9, 2023

Feat: Health check for coin nodes and infoservices

@bludnic
Copy link
Member Author

bludnic commented Nov 10, 2023

Seems like node's height takes up too much space. Proposed solution:

image

Icon: https://pictogrammers.com/library/mdi/icon/cube-outline/

@adamant-al

@adamant-al
Copy link
Member

Added the Format the Nodes screen (screenshots) list item in the Feat: Health check improvements https://trello.com/c/Uhj8LOdD
You can do a part here.
No tooltips.

@bludnic
Merge branch 'dev' into feat/new-healthcheck
a999eeb 
# Conflicts:
#	src/store/modules/erc20/erc20-actions.js
#	src/store/modules/eth-base/eth-base-actions.js
#	src/store/modules/eth/actions.js
@bludnic
Copy link
Member Author

bludnic commented Nov 11, 2023

  • Added cube-icon before node height
  • Fixed conflicts

@bludnic bludnic merged commit 28d1ec7 into dev Nov 11, 2023
3 checks passed
@bludnic bludnic deleted the feat/new-healthcheck branch November 11, 2023 16:08
@github-actions GitHub Actions
Copy link

Successfully tore down https://msg-adamant-pr-547.surge.sh 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martiliones martiliones martiliones approved these changes

@adamant-al adamant-al adamant-al approved these changes

@RealGoodProgrammer RealGoodProgrammer RealGoodProgrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bludnic @martiliones @adamant-al @RealGoodProgrammer