Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tor configuration #47

Merged
merged 24 commits into from
Oct 18, 2023
Merged

Add Tor configuration #47

merged 24 commits into from
Oct 18, 2023

Conversation

bludnic
Copy link
Member

@bludnic bludnic commented Oct 12, 2023

Checklist

  • Add Tor nodes
  • Add explorer URL for Tor
  • Add infoService URL (for Tor as well)
  • Add nodeMinVersion
  • Add website for Tor
  • Add nodeMinVersion
  • Update Swagger types
  • Update README.md. Add Tor examples.
  • Add coin tor nodes
  • ⚠️ Renamed serviceNodes to services (see lisk config @StanislavDevIOS)

Use https://editor.swagger.io/ if you want to test the Swagger schema

@bludnic
Copy link
Member Author

bludnic commented Oct 12, 2023

Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot about coin tor nodes, add them.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Suggest to set minNodeVersion to at least 0.7.0.
  • We suppose infoService's alt_ip's default port is 80.
  • Consider to add btcnode2 + alt_ip + tor, it's working
  • Consider to add dogenode2 + alt_ip + tor, it's working
  • Consider to add ethnode2 + alt_ip + tor, it's working
  • Dash's node2 and node3 are on the way soon @confleux

@adamant-al
Copy link
Member

We can merge it.

@bludnic bludnic merged commit 2b18f9d into dev Oct 18, 2023
@bludnic bludnic deleted the feat/tor-configuration branch October 18, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants