Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.21.0 #93

Merged
merged 19 commits into from
Feb 9, 2023
Merged

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Jan 25, 2023

This PR updates to egui 0.21.0

I would greatly appreciate if you could merge this and publish a new version of egui_dock as soon as you can 🙏

This also adds a small new feature: TabViewer::on_tab_button

@emilk emilk mentioned this pull request Jan 31, 2023
3 tasks
@emilk emilk changed the title WIP: update to latest egui Update to egui 0.21.0 Feb 8, 2023
@emilk emilk marked this pull request as ready for review February 8, 2023 19:46
Cargo.toml Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@emilk
Copy link
Contributor Author

emilk commented Feb 8, 2023

This is finally ready for review @Adanos020

@emilk emilk mentioned this pull request Feb 8, 2023
8 tasks
Cargo.toml Show resolved Hide resolved
@emilk
Copy link
Contributor Author

emilk commented Feb 9, 2023

@Adanos020 usually a user would have:

egui = "0.21"
egui_dock = "0.4"

and it would just work, since the egui = "0.21 line would pull in default_fonts (as would any use of eframe).

This change is really only for the users that are explicitly opting out of default_fonts (because they are installing their own fonts):

egui = { version = "0.21", default-features = false }
egui_dock = "0.4"

I would suspect it to be extremely rare with any users that don't have either egui or eframe in the dependencies, but rely only on egui_dock and use egui_dock::egui when they want to use egui directly. For those users, they would need to add egui = "0.21" to their Cargo.toml to get the default_fonts back.

@Adanos020
Copy link
Owner

@emilk Then before publishing 0.4, I'd add a note about that in the Readme. I'll merge this PR for now and do that in a separate one.

@Adanos020 Adanos020 merged commit 66d9dd5 into Adanos020:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants