4832 / Skipped test #2210
4832 / Skipped test #2210
Conversation
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
There was a problem hiding this comment.
I deleted this test because, under the hood, it is testing the rendering of SVG which creates a Dompoint . The current testing environment is run under jsdom, and SVG is not deeply tested, so calling something like this svg.createSVGPoint() is throwing a type error; please see link. createSVGPoint() is called in the file Tooltip.tsx, line 119.
| act(() => { | ||
| userEvent.selectOptions( |
There was a problem hiding this comment.
This way of selecting an option for a selector was not working, which subsequentially led the test to fail.
| @@ -69,6 +69,7 @@ export const NumFilter = ({ | |||
| <FilterPopup | |||
| parentRef={parentRef} | |||
| ariaLabel={`Filter trades by ${colDef[field].headerName} field value`} | |||
| leftAlignFilter={field !== "tradeId"} | |||
There was a problem hiding this comment.
The alignment for numeric field in the blotter were not displayed in the screen. Please see ReactiveTrader and click the Filter Icon for Notional, or Rate. This is now fixed, see image below:
| @@ -119,33 +119,4 @@ describe("Positions", () => { | |||
|
|
|||
| expect(screen.getByTestId("tooltip").textContent).toBe("AUD -1,557,031") | |||
| }) | |||
|
|
|||
| // TODO (5350): fix test failure - Windows snapshot incompatible with Mac | |||
| it.skip("should display the correct bubble chart", async () => { | |||
There was a problem hiding this comment.
Since the aim was to generate a snapshot, I have removed it as @algreasley suggested that the test should focus on component testing for user events such as clicking a button, etc...
No description provided.