feat: icon refactor #2349
Open
feat: icon refactor #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
algreasley
reviewed
Feb 6, 2025
| @@ -1,4 +1,4 @@ | |||
| export default ( | |||
| export const AppleShareIcon = ( | |||
| <svg width="16" height="16" viewBox="0 0 24 24"> | ||
| <path | ||
| d="M11.9991 21.2501C11.8091 21.2501 11.6191 21.1801 11.4691 21.0301L5.39914 14.9601C5.10914 14.6701 5.10914 14.1901 5.39914 13.9001C5.68914 13.6101 6.16914 13.6101 6.45914 13.9001L11.9991 19.4401L17.5391 13.9001C17.8291 13.6101 18.3091 13.6101 18.5991 13.9001C18.8891 14.1901 18.8891 14.6701 18.5991 14.9601L12.5291 21.0301C12.3791 21.1801 12.1891 21.2501 11.9991 21.2501Z" | ||
| fill="currentColor" |
There was a problem hiding this comment.
would top-level fill work in these icons, per this article
| <svg | ||
| width={width} | ||
| height={height} | ||
| width={18} |
There was a problem hiding this comment.
is hard-coding def what we want?
| <svg width={28} height={28} viewBox="0 0 24 24"> | ||
| <path | ||
| d="M12 19.25C8 19.25 4.75 16 4.75 12C4.75 8 8 4.75 12 4.75C16 4.75 19.25 8 19.25 12C19.25 16 16 19.25 12 19.25ZM12 6.25C8.83 6.25 6.25 8.83 6.25 12C6.25 15.17 8.83 17.75 12 17.75C15.17 17.75 17.75 15.17 17.75 12C17.75 8.83 15.17 6.25 12 6.25Z" | ||
| fill="#292D32" |
| @@ -0,0 +1,12 @@ | |||
| export const SearchIcon = ( | |||
| <svg width="16" height="16" viewBox="0 0 24 24"> | |||
There was a problem hiding this comment.
nit .. sometimes width={16}, sometimes width="16" .. suggest latter, unless we are using expressions ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardise icon use
Add missing icons
Remove unused icons