Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node 12 to node 14 in ci.yml github action #43

Merged
merged 4 commits into from
May 17, 2023

Conversation

c69-addepar
Copy link
Contributor

@c69-addepar c69-addepar commented May 16, 2023

Chore: Since node 12 will stop working in 2 days (May 18th, 2023), we need to update the github actions affected.

Also updated the image to be ubuntu-latest, as the previous one not exist on github anymore.

Ticket: WEBCORE-2057

Release Notes: None

Chore: Since node 12 will stop working in 2 days (May 18th, 2023), we need to update the github actions affected.

Ticket: WEBCORE-2027

Release Notes: None
@bantic
Copy link
Contributor

bantic commented May 17, 2023

I think this is supposed to reference ticket WEBCORE-2034 instead.

This change is fine, but according to https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/ the only thing that is affected is actions, not workflows.

So I don't think using setup-node w/ node-version: 12 will break soon.
Still worth upgrading, of course.

@c69-addepar c69-addepar requested a review from a team May 17, 2023 17:21
@c69-addepar c69-addepar changed the title Updated node 12 to node 14 in ci.yml github action Updated node 12 to node 16 in ci.yml github action May 17, 2023
@c69-addepar c69-addepar changed the title Updated node 12 to node 16 in ci.yml github action Updated node 12 to node 14 in ci.yml github action May 17, 2023
@c69-addepar
Copy link
Contributor Author

c69-addepar commented May 17, 2023

1 of 2 actions (Run test) actually fails with Node16, so i will keep this at Node14.

Run yarn test:ember
yarn run v1.22.19
$ ember test
WARNING: Node v1[6](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:7).20.0 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js. See https://git.io/v[7](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:8)S5n for details.
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
Building
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
node:internal/validators:249
      throw new ERR_INVALID_ARG_TYPE(name, 'Object', value);
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "options" argument must be of type object. Received an instance of Array
    at ChildProcess.target.send (node:internal/child_process:741:7)
    at Array.forEach (<anonymous>)
    at dispatchQueuedRequests (/home/runner/work/ember-classy-page-object/ember-classy-page-object/node_modules/workerpool/lib/WorkerHandler.js:174:21)
    at ChildProcess.<anonymous> (/home/runner/work/ember-classy-page-object/ember-classy-page-object/node_modules/workerpool/lib/WorkerHandler.js:129:7)
    at ChildProcess.emit (node:events:513:2[8](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:9))
    at emit (node:internal/child_process:[9](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:10)46:[14](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:15))
    at processTicksAndRejections (node:internal/process/task_queues:84:[21](https://github.com/Addepar/ember-classy-page-object/actions/runs/5006108868/jobs/8970938172?pr=43#step:6:22)) {
  code: 'ERR_INVALID_ARG_TYPE'
}
error Command failed with exit code 1.

@c69-addepar c69-addepar merged commit 4a269e7 into master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants