-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated node 12 to node 14 in ci.yml github action #43
Conversation
Chore: Since node 12 will stop working in 2 days (May 18th, 2023), we need to update the github actions affected. Ticket: WEBCORE-2027 Release Notes: None
I think this is supposed to reference ticket WEBCORE-2034 instead. This change is fine, but according to https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/ the only thing that is affected is actions, not workflows. So I don't think using |
1 of 2 actions (Run test) actually fails with Node16, so i will keep this at Node14.
|
Chore: Since node 12 will stop working in 2 days (May 18th, 2023), we need to update the github actions affected.
Also updated the image to be
ubuntu-latest
, as the previous one not exist on github anymore.Ticket: WEBCORE-2057
Release Notes: None