Update to released version of ember-cli-page-object v2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascudder
force-pushed
the
page-object-2-release
branch
from
a99e395 to
f5de0ff
Compare
|
Awesome. Yeah IIRC the reason this was pinned to the beta was because the dependency had dropped support for a version of Ember still supported by Ember Table (and used by Addepar at the time). Happily that is no longer the case, and we will be cutting a new major of Ember Table Addepar/ember-table#995 with support for only Ember 3.28+ in the coming weeks. Let me check if this seems like it is unblocked, and if so I could merge this and cut a new minor version (non beta) with this change. |
|
Thanks @mixonic for taking a look and for the explanation on compatibility. Fortunately it looks like we're already on a compatible version of Ember, so If this can make it into a pre-release version of the next release, that would help us out, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the version of ember-cli-page-object from the beta version (
~v2.0.0-beta.3) to the stable released version (^2.1.0) so that it is compatible with a wider range of ember-cli-page-object versions. Additionally, updatesthe
enginesspecification to match the compatibility of ember-cli-page-object.