-
Notifications
You must be signed in to change notification settings - Fork 354
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DOCS: Improve table-customization docs pages
* Move `getRandomInt` helper to utils/generators * Use more explanatory data for table-customization sorting Previously, the data displayed in the table didn't have any difference, row-to-row, so it wasn't obvious that clicking the column headers actually did change the sorting. This copies over the sortable columns/rows data from the sorting docs example. * Interactive sort/resize indicators on customization page On the table customization page, add checkboxes to turn on/off the sort/resize indicators in the header columns, so that docs readers can better understand how they are used. * table-customization: More obvious cell/column customizations Use a SCSS loop to define the `.text-<color>` and `.bg-<color>` style rules. Remove the "text-" prefix from the color names used in code, move this into the template. Make custom cells use a `text-<color>` class. Make custom header cells use a `bg-<color>` class, for variety. Separate some of the reused controller properties so that it's clearer which property is used for which example.
- Loading branch information
Showing
9 changed files
with
195 additions
and
127 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{{! BEGIN-SNIPPET custom-cell.hbs }} | ||
<div class="custom-header {{color}}"> | ||
<div class="custom-header text-{{color}}"> | ||
Cell {{yield}} | ||
</div> | ||
{{! END-SNIPPET }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{{! BEGIN-SNIPPET custom-header.hbs }} | ||
<div class="custom-header {{color}}"> | ||
<div class="custom-header bg-{{color}}"> | ||
Column {{yield}} | ||
</div> | ||
{{! END-SNIPPET }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 1 addition & 4 deletions
5
tests/dummy/app/pods/docs/guides/header/sorting/empty-values/component.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.