Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Ember v1.4.0 #106

Merged
merged 6 commits into from
Apr 1, 2014
Merged

Conversation

petrvolny
Copy link
Contributor

Updated dependency to Ember 1.4.0, Handlebars 1.3.0
Handlebars refactoring:

  • bindAttr -> bind-attr
  • linkTo -> link-to
  • quoted {{action}} names

Relates to #95

@petrvolny petrvolny mentioned this pull request Feb 19, 2014
@bolshchikov
Copy link

Deprecate quoteless action names.

The app code handlebars contains also actions without quotes. Otherwise the app fails on ajax page

@bolshchikov
Copy link

@petrvolny, I think it might also worth to move to Handlerbars v1.3

@petrvolny
Copy link
Contributor Author

Ok, sure. Will fix it soon. Thanks.

@petrvolny
Copy link
Contributor Author

Hey @bolshchikov , can you please try the latest changes and let me know if you are ok with them?

@azirbel
Copy link
Contributor

azirbel commented Mar 24, 2014

Looks good to me - thank you @petrvolny! I'm ready to merge it but will wait a bit to give @bolshchikov some time to weigh in.

@petrvolny
Copy link
Contributor Author

I can imagine that @addepar-andy is using this stuff. Can you confirm that it is ok with your usage? Is it breaking something?

@azirbel
Copy link
Contributor

azirbel commented Mar 27, 2014

@petrvolny, could you also add the changed dist folder? Looks like we didn't update it in the past couple commits but we should be keeping it up to date with development.

@azirbel azirbel mentioned this pull request Mar 27, 2014
@petrvolny
Copy link
Contributor Author

@azirbel, done.

@azirbel
Copy link
Contributor

azirbel commented Apr 1, 2014

I don't think @addepar-andy is using this personally, but it works with Addepar's usage as a whole. I think this is ready to go - merging it in now. Thanks again!

azirbel added a commit that referenced this pull request Apr 1, 2014
@azirbel azirbel merged commit 51d204a into Addepar:master Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants