Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add indeterminate state to parent rows when a child is selected #1114

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lukasnys
Copy link
Contributor

Why?

It's a very common pattern when working with nested checkboxes, that - when selecting a child checkbox - the parent checkbox gets an indeterminate state

What?

Add this indeterminate behaviour

@lukasnys lukasnys force-pushed the grouped-rows-indeterminate branch from e6bf89b to 85abb7f Compare July 23, 2024 11:50
lukasnys added 3 commits July 23, 2024 13:55
in which case we don't show the indeterminate state, since checking children then doesn't "work towards" selecting the parent
@lukasnys
Copy link
Contributor Author

lukasnys commented Dec 4, 2024

I need to change the indeterminate state so all parents (even ones further than 1 level) get isGroupIndeterminate: true when a child is selected.

@lukasnys lukasnys marked this pull request as draft December 4, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant