Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when ember-table dependencies are missing #143

Merged
merged 2 commits into from
Apr 28, 2014

Conversation

petrvolny
Copy link
Contributor

resolves #138

@azirbel
Copy link
Contributor

azirbel commented Apr 28, 2014

Thanks @petrvolny. jquery-mousewheel is another one that's caused issues for people in the past. Most things work without it, but horizontal scrolling breaks. Could you add either an error or warning for that as well?

Also toss in dist files. Otherwise, looks good.

@petrvolny petrvolny closed this Apr 28, 2014
@petrvolny petrvolny reopened this Apr 28, 2014
@petrvolny
Copy link
Contributor Author

Good point. It should be ok now.

azirbel added a commit that referenced this pull request Apr 28, 2014
Throw exception when ember-table dependencies are missing
@azirbel azirbel merged commit 539410f into Addepar:master Apr 28, 2014
Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this pull request Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Better errors when dependencies are missing
2 participants