First selected row visible #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures first selected row visibility.
| @@ -39,6 +39,7 @@ Ember.Table.RowSelectionMixin = Ember.Mixin.create | |||
| rows.objectAt(index).get('content') | |||
| else # setter | |||
| @_calculateSelectionIndices(value) | |||
| @ensureVisible(@get('selectionIndices.0')) | |||
There was a problem hiding this comment.
hey @karlguillotte I think this makes sense. Do you think you could change it to @get('selectionIndices.firstObject') instead of @get('selectionIndices.0')?
There was a problem hiding this comment.
selectionIndices is actually a Ember.Set where keys are the indices.
Even if the Ember.Set API has firstObject property I tried selectionIndices.firstObject and it does not work.
|
hey @karlguillotte could you rebase off master so I could merge it in. Thanks |
billy-addepar
added a commit
that referenced
this pull request
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures first selected row visibility.