Remove problematic CSS !importants #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I also tested on the demo-app branch. |
raemadeline
reviewed
Sep 28, 2016
| @@ -54,7 +54,7 @@ | |||
| } | |||
|
|
|||
| .ember-table-left-table-block .ember-table-cell { | |||
| border-right: 16px solid transparent !important; | |||
raemadeline
approved these changes
Sep 28, 2016
|
retest |
LydiaBarnes
added a commit
that referenced
this pull request
Oct 3, 2016
…ortants Remove problematic CSS !importants
LydiaBarnes
added a commit
that referenced
this pull request
Oct 4, 2016
…ortants Remove problematic CSS !importants
LydiaBarnes
added a commit
that referenced
this pull request
Oct 5, 2016
Merge pull request #410 from Addepar/lydia/remove-problematic-css-importants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring the CSS for tables in the product, I realized there are some
!importants in Ember Table itself that could be removed. I only addressed the couple that were directly affecting our overwriting CSS, I didn't do a major overhaul. The ones I removed weren't even really needed in the first place, the selectors were specific enough already so I have no idea why !important was used.@Addepar/design @cyril-sf @shiller-addepar @embooglement